New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43400: Remove "easy to use" from mock docs #24752
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Doc/library/unittest.mock.rst
Outdated
@@ -30,7 +30,7 @@ module and class level attributes within the scope of a test, along with | |||
some examples of how to use :class:`Mock`, :class:`MagicMock` and | |||
:func:`patch`. | |||
|
|||
Mock is very easy to use and is designed for use with :mod:`unittest`. Mock | |||
Mock is designed for use with :mod:`unittest`. Mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest combining the two sentences.
s/. Mock/, and/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, though I removed the comma in the substitution since the part after "and" is not an independent clause. Thanks for the review! It's a little change, but it's good to make Python more approachable however we can.
726302a
to
ea0da15
Compare
Thanks @eppeters for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
GH-24758 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 2122e48) Co-authored-by: Eddie Peters <eddie@dinogalactic.com>
https://bugs.python.org/issue43400
From the original issue message:
https://bugs.python.org/issue43400