Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41974: Remove part of the doc note regarding complex.__float__ #25197

Merged
merged 1 commit into from Apr 10, 2021
Merged

bpo-41974: Remove part of the doc note regarding complex.__float__ #25197

merged 1 commit into from Apr 10, 2021

Conversation

DevilXD
Copy link
Contributor

@DevilXD DevilXD commented Apr 5, 2021 •
edited

Wasn't sure if there was anything more to add to it, or a simple trim like this is sufficient. Will change if needed.

https://bugs.python.org/issue41974

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@DevilXD

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 5, 2021
gvanrossum
gvanrossum approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks like the best way to deal with this. I'll land once the CLA comes through. Thanks!

@DevilXD
Copy link
Contributor Author

DevilXD commented Apr 9, 2021

Well, looks like the CLA checking site is having problems figuring it out: https://i.imgur.com/NjuuXc4.png

Although, the bug tracker is showing it did go through.

@gvanrossum
Copy link
Member

Must've been a temporary glitch. I'll also add the "skip news" label.

@gvanrossum gvanrossum merged commit ac05f82 into python:master Apr 10, 2021
@DevilXD DevilXD deleted the patch-1 branch April 11, 2021 10:01
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@DevilXD @kreathon
bpo-41974: Remove part of the note regarding complex.__float__ (pytho…
aa5da51 
…nGH-25197)

(The deleted example no longer works and is thus irrelevant.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DevilXD @the-knights-who-say-ni @gvanrossum @bedevere-bot