Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion of pop() result in test_issue_4920 #25209

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix assertion of pop() result in test_issue_4920 #25209

merged 1 commit into from
Apr 7, 2021

Commits on Mar 25, 2021

  1. Fix assertion of pop() result in test_issue_4920 

    The pop method of MutableSet iterates the underlying set object to choose
the item to remove. According the the Python language reference "sets do not
record element position or order of insertion".

Changes the test to not assert concrete result of pop, but just that it
was an item from the set, and that the set shrunk by one.
    @steve-s
    steve-s committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b60f387 View commit details
    Browse the repository at this point in the history