Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42248: [Enum] ensure exceptions raised in _missing_ are released #25350

Merged
merged 1 commit into from Apr 12, 2021
Merged

bpo-42248: [Enum] ensure exceptions raised in _missing_ are released #25350

merged 1 commit into from Apr 12, 2021

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Apr 12, 2021 •
edited by bedevere-bot

@ethanfurman ethanfurman changed the title bpo-42248: [Enum] ensure exceptions raised in _missing__ are released bpo-42248: [Enum] ensure exceptions raised in _missing_ are released Apr 12, 2021
@ethanfurman ethanfurman merged commit 8c14f5a into python:master Apr 12, 2021
@ethanfurman ethanfurman added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Apr 12, 2021
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ethanfurman, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8c14f5a787b21d5a1eae5d5ee981431d1c0e055f 3.8

@miss-islington
Copy link
Contributor

Sorry @ethanfurman, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8c14f5a787b21d5a1eae5d5ee981431d1c0e055f 3.9

ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 12, 2021
@ethanfurman
[3.8] bpo-42248: [Enum] ensure exceptions raised in _missing_ are…
0b5d184 
… released (pythonGH-25350).

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Apr 12, 2021
@ethanfurman
[3.9] bpo-42248: [Enum] ensure exceptions raised in _missing_ are…
abb5398 
… released (pythonGH-25350).

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Apr 12, 2021
@ethanfurman
[3.8] bpo-42248: [Enum] ensure exceptions raised in _missing_ are…
f396a1a 
… released (GH-25350). (GH-25369)

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Apr 12, 2021
@ethanfurman
[3.9] bpo-42248: [Enum] ensure exceptions raised in _missing_ are…
6379924 
… released (GH-25350). (GH-25370)

(cherry picked from commit 8c14f5a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ethanfurman ethanfurman deleted the enum-issue42248 branch April 15, 2021 14:26
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@ethanfurman @kreathon
bpo-42248: [Enum] ensure exceptions raised in _missing_ are relea…
e639767 
…sed (pythonGH-25350)
@Mariatta
Copy link
Member

Mariatta commented Jun 2, 2021

Does this still need backport to 3.8 and 3.9? If not, please remove the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ethanfurman ethanfurman

Labels
needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ethanfurman @miss-islington @Mariatta @the-knights-who-say-ni @bedevere-bot