Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43977: Update pattern matching language reference docs #25917

Merged
merged 2 commits into from May 14, 2021
Merged

bpo-43977: Update pattern matching language reference docs #25917

merged 2 commits into from May 14, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 5, 2021 •
edited by bedevere-bot

Reference to: python/peps#1937 , which updated what is considered a sequence and mapping.

https://bugs.python.org/issue43977

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 5, 2021
@Fidget-Spinner Fidget-Spinner marked this pull request as draft May 5, 2021 15:25
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.10 only security fixes label May 5, 2021
@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review May 5, 2021 15:27
@Fidget-Spinner
Copy link
Member Author

I believe that we can skip news for for this. However, if anyone thinks this needs a news entry I'll add it.

willingc
willingc approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fidget-Spinner. Great clarifications.

@Fidget-Spinner
Copy link
Member Author

Thanks for the review Carol!

@willingc willingc merged commit 53c91ac into python:main May 14, 2021
@miss-islington
Copy link
Contributor

Thanks @Fidget-Spinner for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26117 is a backport of this pull request to the 3.10 branch.

willingc pushed a commit that referenced this pull request May 14, 2021
@miss-islington @Fidget-Spinner
bpo-43977: Update pattern matching language reference docs (GH-25917) (…
e7d25d3 
…GH-26117)

* Update patma language reference with new changes to sequence and mapping

* update 3.10 whatsnew too
(cherry picked from commit 53c91ac)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-Spinner Fidget-Spinner deleted the update-pep634 branch May 16, 2021 07:49
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fidget-Spinner @miss-islington @bedevere-bot @willingc @the-knights-who-say-ni