Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam #25989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uniocto
Copy link
Contributor

@uniocto uniocto commented May 8, 2021

@iritkatriel
Copy link
Member

iritkatriel commented May 8, 2021

Change the title of the PR to something like:
bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam.

@uniocto uniocto changed the title bpo-24147: Apply Brandon Milam's patch about csv doc bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam. May 8, 2021
@uniocto uniocto changed the title bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam. bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam May 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 8, 2021
@MaxwellDupre
Copy link
Contributor

Doesn't compile:
fix-issue-24147 $…  make -C Doc/ html
make: Entering directory '/home/me/Documents/GitHub/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -W . build/html
Running Sphinx v4.5.0
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 487 source files that are out of date
updating environment: 0 added, 447 changed, 2 removed
reading sources... [100%] whatsnew/index
Warning, treated as error:
/home/me/Documents/GitHub/cpython/Doc/c-api/complex.rst:49:Error in declarator or parameters
Error in declarator or parameters
Invalid C declaration: Expected identifier, got user-defined keyword: complex. Remove it from c_extra_keywords to allow it as identifier.
Currently c_extra_keywords is ['alignas', 'alignof', 'bool', 'complex', 'imaginary', 'noreturn', 'static_assert', 'thread_local']. [error at 39]
Py_complex _Py_c_neg(Py_complex complex)
make: *** [Makefile:51: build] Error 2
make: Leaving directory '/home/me/Documents/GitHub/cpython/Doc'

The target is Python 2, would it be possible to re-target on the latest version?
The CSV Doc hasn't changed so still relevant.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants