Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43795: Reword paragraph on specific value for Py_LIMITED_API #26101

Merged
merged 1 commit into from May 14, 2021
Merged

bpo-43795: Reword paragraph on specific value for Py_LIMITED_API #26101

merged 1 commit into from May 14, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented May 13, 2021 •
edited by bedevere-bot

I spent some time on the wording here. Hopefully it is clearer when the 3 value is explained in terms of its longer equivalent.

https://bugs.python.org/issue43795

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 13, 2021
corona10
corona10 approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

willingc
willingc approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @encukou.

@willingc willingc merged commit ddd30b2 into python:main May 14, 2021
@encukou encukou deleted the pep652-document branch May 14, 2021 07:52
@encukou encukou added the needs backport to 3.10 only security fixes label May 14, 2021
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26123 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 14, 2021
@encukou
Copy link
Member Author

encukou commented May 14, 2021

Thank you for the reviews!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2021
@encukou @miss-islington
Reword paragraph on specific value for Py_LIMITED_API (pythonGH-26101)
e38992e 
(cherry picked from commit ddd30b2)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request May 14, 2021
@miss-islington @encukou
Reword paragraph on specific value for Py_LIMITED_API (GH-26101) (GH-…
5abc681 
…26123)

(cherry picked from commit ddd30b2)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@encukou encukou mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@encukou @miss-islington @bedevere-bot @willingc @corona10 @erlend-aasland @Fidget-Spinner @the-knights-who-say-ni