Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held #26551

Merged
merged 1 commit into from Jun 5, 2021
Merged

bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held #26551

merged 1 commit into from Jun 5, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 5, 2021 •
edited by miss-islington

https://bugs.python.org/issue44304

Automerge-Triggered-By: GH:pablogsal

@pablogsal
Copy link
Member Author

CC: @erlend-aasland

erlend-aasland
erlend-aasland approved these changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant! LGTM.

@pablogsal pablogsal merged commit 6e3b7cf into python:main Jun 5, 2021
@pablogsal pablogsal deleted the bpo-44304 branch June 5, 2021 22:41
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26552 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2021
@pablogsal @miss-islington
bpo-44304: Ensure the sqlite3 destructor callback is always called wi…
681328c 
…th the GIL held (pythonGH-26551)

(cherry picked from commit 6e3b7cf)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 5, 2021
@miss-islington @pablogsal
bpo-44304: Ensure the sqlite3 destructor callback is always called wi…
317e9ed 
…th the GIL held (GH-26551) (GH_26552)

(cherry picked from commit 6e3b7cf)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @miss-islington @bedevere-bot @erlend-aasland @the-knights-who-say-ni