bpo-44426: Use of 'complex' as a variable name confuses recent Sphinx; change to 'num' #26744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
added
docs
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 16, 2021
…nge it to 'num'. (pythonGH-26744) (cherry picked from commit 7247f6f) Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
|
GH-26760 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 16, 2021
…nge it to 'num'. (pythonGH-26744) (cherry picked from commit 7247f6f) Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
|
GH-26761 is a backport of this pull request to the 3.9 branch. |
mdickinson
pushed a commit
that referenced
this pull request
Jun 16, 2021
mdickinson
pushed a commit
that referenced
this pull request
Jun 16, 2021
jdevries3133
pushed a commit
to jdevries3133/cpython
that referenced
this pull request
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 4.0.2 misidentifies the name 'complex' as a C keyword, and issues a warning as a result. Sphinx is wrong here:
complexis not a keyword (it's a macro), andPy_complex _Py_c_neg(Py_complex complex);is a valid C declaration (unlesscomplex.hhas been included). Nevertheless, it's not a great name. This PR changes it tonum, which is already used elsewhere in the same file.https://bugs.python.org/issue44426