Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] bpo-43795: Don't list private names in the limited API (GH-26740) #26753

Merged
merged 1 commit into from Jun 16, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 16, 2021

  • Use the public alias PyFrameObject rather than _frame
  • Remove _node, which disappeared in 3.9 along with the old parser
  • Ensure private (underscore-prefixed) names are not on the Limited API list. (They can be part of the stable ABI, though, e.g. as implementation details of macros.)

(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin encukou@gmail.com

https://bugs.python.org/issue43795

* Remove struct _node from the stable ABI list

This struct was removed along with the old parser in Python 3.9 (PEP 617)

* Stable ABI list: Use the public name "PyFrameObject" rather than "_frame"

* Ensure limited API doesn't contain private names

Names prefixed by an underscore are private by definition.

* Add a blurb
(cherry picked from commit 7cad9cb)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@miss-islington
Copy link
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

@encukou
Copy link
Member

encukou commented Jun 16, 2021

cc @pablogsal – stable ABI doc fix & additional check

@miss-islington
Copy link
Contributor Author

@encukou: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants