bpo-30910 - Add fexceptions to ppc64le build #2682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoalr
force-pushed
the
add-fexceptions
branch
from
3439d2d
to
f228839
Compare
This enables C++ code that interoperate with CPython to deal with exceptions properly on ppc64le systems. PyTorch/Torch is an example of a project that explicits this issue.
|
Can someone review this PR, please? :) |
|
Ping |
|
@Haypo, Could you or someone else review this PR? |
|
@lbianc : discussion is taking place on http://bugs.python.org/issue30910 |
|
Thank you for the PR. I explained on the issue why we won't be merging this, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -fexception flag is needed to correctly deal with exceptions in code that is written in both C and C++.