bpo-44702: Remove ambiguity in sentence #27676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
approved these changes
Aug 9, 2021
|
Thanks, @meowmeowmeowcat and congrats on your first PR! 🎉 |
|
@meowmeowmeowcat: Status check is done, and it's a success ✅ . |
rhettinger
reviewed
Aug 10, 2021
| Not all objects can be weakly referenced; those objects which can include class | ||
| instances, functions written in Python (but not in C), instance methods, sets, | ||
| frozensets, some :term:`file objects <file object>`, :term:`generators <generator>`, | ||
| Not all objects can be weakly referenced. Objects which support weak references |
There was a problem hiding this comment.
Perhaps change "which" to "that".
There was a problem hiding this comment.
I agree with your suggestion. However, is it worth to open a new PR for fixing this?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44702
Automerge-Triggered-By: GH:pablogsal