Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-14853: add back the stdin test, skip if stdin is redirected #27694

Merged
merged 2 commits into from Aug 9, 2021
Merged

bpo-14853: add back the stdin test, skip if stdin is redirected #27694

merged 2 commits into from Aug 9, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 9, 2021 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Aug 9, 2021
gpshead
gpshead approved these changes Aug 9, 2021
View reviewed changes
Lib/test/test_file.py Outdated Show resolved Hide resolved
@iritkatriel iritkatriel merged commit 8ed1833 into python:main Aug 9, 2021
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2021
@iritkatriel @miss-islington
bpo-14853: add back the stdin test, skip if stdin is redirected (pyth…
17fce20 
…onGH-27694)

(cherry picked from commit 8ed1833)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 9, 2021
@bedevere-bot
Copy link

GH-27697 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

GH-27698 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2021
@iritkatriel @miss-islington
bpo-14853: add back the stdin test, skip if stdin is redirected (pyth…
35c6829 
…onGH-27694)

(cherry picked from commit 8ed1833)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel iritkatriel deleted the bpo-14853 branch August 9, 2021 22:39
ambv pushed a commit that referenced this pull request Aug 10, 2021
@miss-islington @iritkatriel
bpo-14853: add back the stdin test, skip if stdin is redirected (GH-2…
897c870 
…7694) (GH-27698)

(cherry picked from commit 8ed1833)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 10, 2021
@miss-islington @iritkatriel
bpo-14853: add back the stdin test, skip if stdin is redirected (GH-2…
4e0147e 
…7694)

(cherry picked from commit 8ed1833)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iritkatriel @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni