Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44878: Remove loop from interpreter. All dispatching is done by gotos. #27727

Merged
merged 2 commits into from Aug 12, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 11, 2021

This PR is mostly reformatting the body of the loop.

The real diff (without whitespace changes): https://github.com/python/cpython/pull/27727/files?w=1

https://bugs.python.org/issue44878

@sweeneyde
Copy link
Member

I wonder whether it would be clearer for git blame reasons to just change for (;;) { to {. I believe there may also be a different way to ignore certain commits in git blame, but I don't know how easy/reliable that is.

@markshannon
Copy link
Member Author

I'm already to blame for the state of the bytecode interpreter 😄

I will do that, though. The historical record is worth preserving where we can.

@markshannon markshannon merged commit a530a95 into python:main Aug 12, 2021
@markshannon markshannon deleted the ceval-remove-loop branch August 23, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants