Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42527: Use ignore mode instead strict for headers enconding in order to encode headers with special chars like emojis #27948

Closed
wants to merge 6 commits into from
Closed

bpo-42527: Use ignore mode instead strict for headers enconding in order to encode headers with special chars like emojis #27948

wants to merge 6 commits into from

Conversation

carlosgalvez-tiendeo
Copy link

@carlosgalvez-tiendeo carlosgalvez-tiendeo commented Aug 25, 2021 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@carlosgalvez-tiendeo

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@carlosgalvez-tiendeo carlosgalvez-tiendeo changed the title bpo-42527: Use utf-8 instead of latin-1 bpo-42527: Use ignore mode instead strict for headers enconding in order to encode headers with special chars like emojis Aug 25, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 25, 2021
MaxwellDupre
MaxwellDupre approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTN but cant figure out how to connect Dängerous Mind and 🛒!

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2022
@wangyanfengp wangyanfengp mannequin mentioned this pull request Apr 10, 2022
Closed
@encukou
Copy link
Member

encukou commented Mar 27, 2024

Sorry, we don't want 🛒 here :(
See the issue.

@encukou encukou closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carlosgalvez-tiendeo @the-knights-who-say-ni @encukou @MaxwellDupre @ezio-melotti @bedevere-bot