Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45288: Inspect - Added sort_result parameter on getmembers function. #28547

Closed
wants to merge 1 commit into from
Closed

bpo-45288: Inspect - Added sort_result parameter on getmembers function. #28547

wants to merge 1 commit into from

Conversation

Patitotective
Copy link

@Patitotective Patitotective commented Sep 24, 2021

Added sort_result parameter (bool=True) on getmembers function inside Lib/inspect.py, that, as it name says, allows you to getmembers result without sorting it.
I'm needed of this and it seems impossible to achieve because of 367 line:

results.sort(key=lambda pair: pair[0])

Any other solution is very welcomed.

(I need it because I'm working on an API Reference creator and I think it would be better if it the members are ordered in the same order you define them.)

https://bugs.python.org/issue45288

Added `sort_result` parameter (`bool=True`)  on `getmembers` function, that, as it name says, allows you to `getmembers` result without sorting it.
I'm needed of this and it seems impossible to achieve because of [`367` line](https://github.com/python/cpython/blob/3.9/Lib/inspect.py#L367).
Any other solution is very welcomed.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Patitotective

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Patitotective
Copy link
Author

Not sure if I should create a bug on bugs.python.org even if this is not an issue.

@Patitotective Patitotective changed the title Added sort_result parameter on getmembers function. Added sort_result parameter on getmembers function (Lib/inspect.py). Sep 24, 2021
@Patitotective Patitotective changed the title Added sort_result parameter on getmembers function (Lib/inspect.py). **Inspect** - Added sort_result parameter on getmembers function. Sep 24, 2021
@Patitotective Patitotective changed the title **Inspect** - Added sort_result parameter on getmembers function. Inspect - Added sort_result parameter on getmembers function. Sep 24, 2021
@Patitotective Patitotective changed the title Inspect - Added sort_result parameter on getmembers function. bpo-45288 Inspect - Added sort_result parameter on getmembers function. Sep 25, 2021
@Patitotective Patitotective changed the title bpo-45288 Inspect - Added sort_result parameter on getmembers function. bpo-45288: Inspect - Added sort_result parameter on getmembers function. Sep 25, 2021
@Patitotective
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants