[3.3][security] bpo-22928: Disabled HTTP header injections in http.client #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original patch by Demian Brecht. Changed for the 3.3 backport: * remove subTest() from change * _is_legal_header_name regex: replace .fullmatch with .match, but add \A at start and \Z at end of the regex (cherry picked from commit a112a8a)
vstinner
changed the title
|
About the CI: test_pty failed once, but passed when run again. It seems like on 3.3, if a test fails once, the overall test suite is considered as failed, even if the test pass when run again. On all other branches, regrtest would succeed in that case. |
|
I scheduled a new Travis CI run and now all tests fail (test_pty didn't fail). |
|
Oh, @serhiy-storchaka proposed almost the same PR a few days ago: PR #2817. I will close this one, once @serhiy-storchaka updated his PR with my suggestions. |
|
Abandonned in favor of @serhiy-storchaka PR #2817 which now LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original patch by Demian Brecht.
Changed for the 3.3 backport:
add \A at start and \Z at end of the regex
(cherry picked from commit a112a8a)
https://bugs.python.org/issue22928