Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45401: Fix ResourceWarning in test_logging #28865

Closed
wants to merge 1 commit into from
Closed

bpo-45401: Fix ResourceWarning in test_logging #28865

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 11, 2021 •
edited by bedevere-bot

Fix ResourceWarning in test_logging.test_should_not_rollover().

https://bugs.python.org/issue45401

@vstinner
bpo-45401: Fix ResourceWarning in test_logging
5ec69ad 
Fix ResourceWarning in test_logging.test_should_not_rollover().
@vstinner vstinner requested a review from vsajip as a code owner October 11, 2021 07:58
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 11, 2021
@vstinner
Copy link
Member Author

@serhiy-storchaka was faster: PR #28864. I close my PR.

@vstinner vstinner closed this Oct 11, 2021
@vstinner vstinner deleted the test_logging_res_warn branch October 11, 2021 08:00
@vstinner vstinner mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot