Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89682: [doc] reword docstring of __contains__ to clarify that it returns a bool #29043

Merged
merged 6 commits into from Nov 26, 2022

Conversation

ivanistheone
Copy link
Contributor

@ivanistheone ivanistheone commented Oct 18, 2021

I was looking to implement a "custom object" to represent intervals of numbers

e.g. if x in interval(2,4) will be True if (x >= 2) and (x < 4).

I looked up help(list.__contains__) and it says "Return key in self" which I interpreted as returning the actual key, not a boolean. A moment of confusion ensured and I tested [2,3].__contains__(2) to check that return value of __contains__ is indeed boolean.

The docstring change suggestion makes the return type of __contains__ clearer.

A type hint for old school people who ? methods in jupyter notebooks ;)

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ivanistheone

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ivanistheone
Copy link
Contributor Author

ivanistheone commented Oct 18, 2021

git diff --color-words for this PR

Screen Shot 2021-10-18 at 6 56 44 PM

  • red = words removed
  • blue = words added

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 18, 2021
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Objects/typeobject.c Outdated Show resolved Hide resolved
@iritkatriel iritkatriel changed the title doc: issue45519 Minor clarification in doc string for __contains__ builtin method gh-89682: [doc]Minor clarification in doc string for __contains__ builtin method Nov 26, 2022
@iritkatriel iritkatriel changed the title gh-89682: [doc]Minor clarification in doc string for __contains__ builtin method gh-89682: [doc] reword docstring of __contains__ method to clarify that it returns a bool Nov 26, 2022
@iritkatriel iritkatriel removed the stale Stale PR or inactive for long period of time. label Nov 26, 2022
@iritkatriel
Copy link
Member

We'll need a news file for this. It's minor, but it touches a builtin.

@iritkatriel iritkatriel changed the title gh-89682: [doc] reword docstring of __contains__ method to clarify that it returns a bool gh-89682: [doc] reword docstring of __contains__ to clarify that it returns a bool Nov 26, 2022
this suggested by iritkatriel

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@iritkatriel iritkatriel self-assigned this Nov 26, 2022
@iritkatriel
Copy link
Member

Thanks, I'll merge once CI completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants