Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing import in dataclass code snippet #29214

Merged
merged 1 commit into from Feb 14, 2022
Merged

Conversation

LeoHuckvale
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@LeoHuckvale

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 25, 2021
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import is indeed missing, thanks! But you need to sign CLA to be able to contibute 🙂

@LeoHuckvale
Copy link
Contributor Author

@sobolevn done - may take a day to come through though.

@CoolCat467
Copy link

@LeoHuckvale I have noticed that the CLA check does not actually occur automatically every day like it claims to, but there we go.

@CoolCat467
Copy link

@sobolevn CLA signed

@Mariatta Mariatta closed this Feb 14, 2022
@Mariatta Mariatta reopened this Feb 14, 2022
@Mariatta Mariatta added the needs backport to 3.10 only security fixes label Feb 14, 2022
@Mariatta Mariatta merged commit ad4e8d2 into python:main Feb 14, 2022
@LeoHuckvale LeoHuckvale deleted the patch-1 branch February 15, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir needs backport to 3.10 only security fixes skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants