Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45693: Document port parameter to loop.create_server #29760

Merged
merged 1 commit into from Nov 24, 2021

Conversation

jcrist
Copy link
Contributor

@jcrist jcrist commented Nov 24, 2021

Document the port parameter to loop.create_server in asyncio. In
particular, note that if host resolves to multiple network interfaces,
passing in port=0 will result in a different random unused port being
used for each interface.

https://bugs.python.org/issue45693

Automerge-Triggered-By: GH:ericvsmith

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@miss-islington
Copy link
Contributor

@jcrist: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d71c7bc into python:main Nov 24, 2021
@miss-islington
Copy link
Contributor

Thanks @jcrist for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2021
…H-29760)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit d71c7bc)

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
@bedevere-bot
Copy link

GH-29762 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 24, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2021
…H-29760)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit d71c7bc)

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
@bedevere-bot
Copy link

GH-29763 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 24, 2021
@bedevere-bot
Copy link

GH-29764 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 24, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2021
…H-29760)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit d71c7bc)

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
ericvsmith pushed a commit that referenced this pull request Nov 24, 2021
… (GH-29762)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit d71c7bc)

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
ericvsmith pushed a commit that referenced this pull request Nov 24, 2021
… (GH-29763)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit d71c7bc)

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>

Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
…H-29760)

Document the `port` parameter to `loop.create_server` in `asyncio`. In
particular, note that if `host` resolves to multiple network interfaces,
passing in `port=0` will result in a different random unused port being
used for each interface.

Automerge-Triggered-By: GH:ericvsmith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants