Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45963: Fix leak when an exception is raised during generator creation. #29960

Merged
merged 1 commit into from Dec 7, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 7, 2021

Mark generator as owning the frame before initializing the locals, so that the specials get cleared in case of error.

https://bugs.python.org/issue45963

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 3964f2c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@pablogsal
Copy link
Member

Hummm, there is this failure on the Gentoo builder:

test_callbacks (ctypes.test.test_as_parameter.AsParamPropertyWrapperTestCase) ... Fatal Python error: Illegal instruction

@pablogsal pablogsal merged commit 064e53d into python:main Dec 7, 2021
@markshannon markshannon deleted the fix-refleak-generator branch January 6, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants