Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46021: fcntl module update supporting FreeBSD's F_KINFO proposal. #30000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-46021: fcntl module update supporting FreeBSD's F_KINFO proposal. #30000

wants to merge 1 commit into from
+41 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Dec 9, 2021 •
edited by bedevere-bot

@devnexen devnexen changed the title fcntl module update supporting FreeBSD's F_KINFO proposal. bpo-46021: fcntl module update supporting FreeBSD's F_KINFO proposal. Dec 9, 2021
tiran
tiran requested changes Dec 9, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include

  • blurb (news entry)
  • documentation update
  • tests
  • configure.ac header check

Modules/fcntlmodule.c
Comment on lines +18 to +20
#ifdef __FreeBSD__
#include <sys/user.h>
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an AC_CHECK_HEADERS check in configure.ac

Modules/fcntlmodule.c
Comment on lines +116 to +121
if (ret) {
PyDict_SetItemString(ret, "status", PyLong_FromLong(f.kf_status));
PyDict_SetItemString(ret, "type", PyLong_FromLong(f.kf_type));
PyDict_SetItemString(ret, "offset", PyLong_FromLongLong(f.kf_offset));
PyDict_SetItemString(ret, "path", PyBytes_FromString(f.kf_path));
return ret;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fcntl.fcntl() returns either an integer or bytes. If F_KINFO needs a different return type, then it would be better to implement the feature as a new platform-specific function in the fcntl module, e.g. fcntl.kinfo(fd: int) -> dict.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 9, 2022
@devnexen devnexen mannequin mentioned this pull request Apr 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran requested changes

Assignees
No one assigned
Labels
awaiting changes OS-freebsd stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@devnexen @bedevere-bot @tiran @vstinner @the-knights-who-say-ni @ezio-melotti