New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46113: Fixes in built in types documentation #30167
bpo-46113: Fixes in built in types documentation #30167
Conversation
help(dict) displays/show kwargs dict(**kwargs) __init__(self, /, *args, **kwargs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Mostly looks good to me. For the sake of other reviewers, the changes are:
- Make bullet point periods consistent
- Make repl output more accurate. The current examples are slightly wrong.
I have a few questions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Fidget-Spinner I have no objections to the PR.
Please feel free to merge when you are ready.
Thanks @vivekvashist for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
* FixGH-1 - isidentifier() function output * FixGH-2 Update the str.splitlines() function parameter * FixGH-3 Removed unwanted full stop for str and bytes types double quotes examples. * FixGH-4 Updated class dict from **kwarg to **kwargs (cherry picked from commit 6f2df42) Co-authored-by: Vivek Vashist <vivekvashist@gmail.com>
* FixGH-1 - isidentifier() function output * FixGH-2 Update the str.splitlines() function parameter * FixGH-3 Removed unwanted full stop for str and bytes types double quotes examples. * FixGH-4 Updated class dict from **kwarg to **kwargs (cherry picked from commit 6f2df42) Co-authored-by: Vivek Vashist <vivekvashist@gmail.com>
GH-30186 is a backport of this pull request to the 3.10 branch. |
GH-30187 is a backport of this pull request to the 3.9 branch. |
Thanks for the review @asvetlov. It's always nice to have a second pair of eyes. Thank you @vivekvashist for fixing up the docs and answering my questions. |
* Fix-1 - isidentifier() function output * Fix-2 Update the str.splitlines() function parameter * Fix-3 Removed unwanted full stop for str and bytes types double quotes examples. * Fix-4 Updated class dict from **kwarg to **kwargs (cherry picked from commit 6f2df42) Co-authored-by: Vivek Vashist <vivekvashist@gmail.com>
* Fix-1 - isidentifier() function output * Fix-2 Update the str.splitlines() function parameter * Fix-3 Removed unwanted full stop for str and bytes types double quotes examples. * Fix-4 Updated class dict from **kwarg to **kwargs (cherry picked from commit 6f2df42) Co-authored-by: Vivek Vashist <vivekvashist@gmail.com>
https://bugs.python.org/issue46113