Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45496: Allow flexibility in winfo_rgb tests #30185

Merged
merged 4 commits into from Dec 26, 2021

Conversation

E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Dec 18, 2021

Allow a margin of 0.05% per colour channel to avoid tests failing on different hardware.

https://bugs.python.org/issue45496

@E-Paine
Copy link
Contributor Author

E-Paine commented Dec 18, 2021

Windows test failure is unrelated

@miss-islington
Copy link
Contributor

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@bedevere-bot
Copy link

GH-30266 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@bedevere-bot bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Dec 26, 2021
@bedevere-bot
Copy link

GH-30267 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@E-Paine E-Paine deleted the tkinter-winfo-rgb branch January 6, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants