Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation in datetime module strftime-and-strptime-behavior fix typo in '%W' format code description #30232

Merged
merged 2 commits into from Jan 19, 2022

Conversation

binary-signal
Copy link
Contributor

@binary-signal binary-signal commented Dec 22, 2021

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded decimal number' so it's in line with the example having leading zeros. Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Dec 22, 2021
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@binary-signal

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@binary-signal binary-signal changed the title Update documentation in datetime module strftime-and-strptime-behavior fix typo in '%W' format code description No issue # Update documentation in datetime module strftime-and-strptime-behavior fix typo in '%W' format code description Dec 31, 2021
@binary-signal binary-signal changed the title No issue # Update documentation in datetime module strftime-and-strptime-behavior fix typo in '%W' format code description Update documentation in datetime module strftime-and-strptime-behavior fix typo in '%W' format code description Dec 31, 2021
@binary-signal
Copy link
Contributor Author

Hi @AlexWaygood could you please add a no-issue label to this issue?

@AlexWaygood
Copy link
Member

Hi @binary-signal — welcome to cpython! 😀

I'm afraid I'm not going to add the skip-issue label here 🙂 Generally speaking, all PRs except really trivial typo fixes should be linked to a BPO issue for cpython, I'm afraid. As a non-expert on the datetime module, it's not immediately obvious to me that this meets that criteria.

I recommend you create a BPO issue, and change the title of this PR to include the BPO number (the bots will automatically insert a link to the ticket). If you do so, it is more likely that your PR will receive attention from the right core devs and (hopefully) get merged 🙂

@pganssle
Copy link
Member

It's ok, I don't think we need an issue for this. I'll try to take a look this weekend.

@AlexWaygood
Copy link
Member

Thanks @pganssle!

binary-signal and others added 2 commits January 19, 2022 12:21
update documentation for format code '%W' to 'a zero padded   decimal number'  like mentioned in the '%U' description
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the document uses "zero-padded" instead of "zero padded", which I guess was an oversight in the %U documentation, so I've gone ahead and pushed that change to both %W and %U and rebased against the most recent main. This looks good to merge now.

@miss-islington
Copy link
Contributor

@binary-signal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d45cd2d into python:main Jan 19, 2022
@miss-islington
Copy link
Contributor

Thanks @binary-signal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
…r fix typo in '%W' format code description (pythonGH-30232)

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded   decimal number' so it's in line with the example having leading zeros.  Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle
(cherry picked from commit d45cd2d)

Co-authored-by: Evan <binary-signal@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 19, 2022
@bedevere-bot
Copy link

GH-30702 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
…r fix typo in '%W' format code description (pythonGH-30232)

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded   decimal number' so it's in line with the example having leading zeros.  Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle
(cherry picked from commit d45cd2d)

Co-authored-by: Evan <binary-signal@users.noreply.github.com>
@bedevere-bot
Copy link

GH-30703 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 19, 2022
miss-islington added a commit that referenced this pull request Jan 19, 2022
…r fix typo in '%W' format code description (GH-30232)

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded   decimal number' so it's in line with the example having leading zeros.  Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle
(cherry picked from commit d45cd2d)

Co-authored-by: Evan <binary-signal@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Jan 23, 2022
…r fix typo in '%W' format code description (GH-30232) (GH-30703)

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded   decimal number' so it's in line with the example having leading zeros.  Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle
(cherry picked from commit d45cd2d)

Co-authored-by: Evan <binary-signal@users.noreply.github.com>

Co-authored-by: Evan <binary-signal@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…r fix typo in '%W' format code description (pythonGH-30232) (pythonGH-30703)

A small change to the documentation of datetime module , in the format codes section of stftime and strptime. Changed the description of format code '%W' from 'as a decimal number' to 'a zero padded   decimal number' so it's in line with the example having leading zeros.  Similar to the format code '%U' above.

Automerge-Triggered-By: GH:pganssle
(cherry picked from commit d45cd2d)

Co-authored-by: Evan <binary-signal@users.noreply.github.com>

Co-authored-by: Evan <binary-signal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants