bpo-45853: fix misspelling in pathlib.py and an unused import #30292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 30, 2021
| @@ -8,7 +8,7 @@ | |||
| import sys | |||
| import warnings | |||
| from _collections_abc import Sequence | |||
| from errno import EINVAL, ENOENT, ENOTDIR, EBADF, ELOOP | |||
| from errno import ENOENT, ENOTDIR, EBADF, ELOOP | |||
There was a problem hiding this comment.
Removing EINVAL can be a breaking change, since it might be used by 3rd party code.
It was there for 10+ years: https://github.com/python/cpython/blame/7ef1697be54a74314d5214d9ba0580d4e620694c/Lib/pathlib.py#L10
There was a problem hiding this comment.
If it is used by 3rd party code, it is a bug in that code.
serhiy-storchaka
approved these changes
Dec 30, 2021
| @@ -8,7 +8,7 @@ | |||
| import sys | |||
| import warnings | |||
| from _collections_abc import Sequence | |||
| from errno import EINVAL, ENOENT, ENOTDIR, EBADF, ELOOP | |||
| from errno import ENOENT, ENOTDIR, EBADF, ELOOP | |||
There was a problem hiding this comment.
If it is used by 3rd party code, it is a bug in that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not adding a news entry as the fix is not for a public name and unlikely to be used in downstream projects.
https://bugs.python.org/issue45853