bpo-46296: add a test case for enum.py which covers _use_args == True and _member_type_ == object
#30458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
asyncio test sometimes fails on win, reopening. |
ethanfurman
reviewed
Jan 7, 2022
There was a problem hiding this comment.
The premise is indeed untrue: _use_args_ can be True when _member_type_ is object.
The branch is taken under rare conditions with a mixed-in type has a __new__ with a complicated method of determining the value attribute.
The branch is taken when a custom __new__ has been defined: _use_args_ will then be True, and if _value_ has not been set then __set_name__ will try to call object.__new__(cls, *args) which will fail. The if _member_type_ is object branch is there to set the _value_ attribute, since it can.
|
@ethanfurman yes, you are right. Now this case is covered. |
sobolevn
changed the title
enum.pyenum.py which covers _use_args == True and _member_type_ == object
|
Thank you! Several other missing branches left 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I am missing something and
_member_type_can beobjectwhile_use_args_isTrue, then this PR can be converted into a coverage increasing one.I will just add a sample to cover this case (but, again, I can't come up with one).
https://bugs.python.org/issue46296