Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (GH-2822) #3053

Merged
merged 2 commits into from Aug 10, 2017
Merged

[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (GH-2822) #3053

merged 2 commits into from Aug 10, 2017

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Aug 10, 2017 •
edited by bedevere-bot

mlouielu and others added 2 commits August 9, 2017 21:16
@mlouielu @terryjreedy
[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (pyt…
f937f33 
…hon#2822)
@terryjreedy
[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (pyt…
5cfe6c5 
…honGH-2822)

Idlelib.calltips.get_argspec now uses inspect.signature instead of inspect.getfullargspec, like help() does.  This improves the signature in the call tip in a few different cases, including builtins converted to provide a signature.  A message is added if the object is not callable, has an invalid signature, or if it has positional-only parameters.
Patch by Louie Lu..
(cherry picked from commit 3b0f620)
@bedevere-bot bedevere-bot mentioned this pull request Aug 10, 2017
Merged
@terryjreedy terryjreedy merged commit 646f6c3 into python:3.6 Aug 10, 2017
@terryjreedy terryjreedy deleted the backport-3b0f620-3.6 branch August 10, 2017 04:47
@terryjreedy
Copy link
Member Author

The test part of the patch touched the one code line in idlelib where 3.6 and 3.7 differ, and created another conflict, so I had to resolve the merge conflict (see comment in diff) and test myself. If cherry_picker had run without conflict, I would have closed and re-open to get Appveyor to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terryjreedy @the-knights-who-say-ni @mlouielu