bpo-46521: Fix codeop to use a new partial-input mode of the parser

[pablogsal]

https://bugs.python.org/issue46521

[terryjreedy]

I am overall pleased, pending manual tests. The 4 failures use one tricky tkinter-based test fixture that has been problematic before. They only occur with GHA Windows and Ubuntu but not GHA Mac nor any system with Pipelines. The latter plays with stdout and that might be a clue. When I get back to this, I hope in a few hours, I will start with manual tests, including with the code in the passing and failing tests, to see if the failure is in live IDLE or only the test simulation thereof.

[terryjreedy]

Live test: any incomplete line fails due to new flags parameter.

raceback (most recent call last):
  File "F:\dev\3x\Lib\tkinter\__init__.py", line 1920, in __call__
    return self.func(*args)
           ^^^^^^^^^^^^^^^^
  File "F:\dev\3x\Lib\idlelib\multicall.py", line 176, in handler
    r = l[i](event)
        ^^^^^^^^^^^
  File "F:\dev\3x\Lib\idlelib\pyshell.py", line 1330, in enter_callback
    self.runit()
    ^^^^^^^^^^^^
  File "F:\dev\3x\Lib\idlelib\pyshell.py", line 1368, in runit
    input_is_complete = self.interp.runsource(line)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\3x\Lib\idlelib\pyshell.py", line 702, in runsource
    return InteractiveInterpreter.runsource(self, source, filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\3x\Lib\code.py", line 63, in runsource
    code = self.compile(source, filename, symbol)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\3x\Lib\codeop.py", line 174, in __call__
    return _maybe_compile(self.compiler, source, filename, symbol)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\dev\3x\Lib\codeop.py", line 91, in _maybe_compile
    code1 = compiler(source + "\n", filename, symbol, flags=ast.PyCF_ALLOW_INCOMPLETE_INPUT)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Compile.__call__() got an unexpected keyword argument 'flags'

test_codeop does not cover all of the preliminary paths. Apparent fix is to change beginning of Command.__call same way you did _compile, to

    def __call__(self, source, filename, symbol, flags=0):
        codeob = compile(source, filename, symbol, self.flags | flags, True)

With this, test_idle passes for me.

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 20677c3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

[terryjreedy]

/pourpose/purpose/

[pablogsal]

Thanks!

[miss-islington]

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

[miss-islington]

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 69e10976b2e7682c6d57f4272932ebc19f8e8859 3.10

[bedevere-bot]

GH-31213 is a backport of this pull request to the 3.10 branch.