Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46588: fix typo in test_calltip.py #31027

Closed
wants to merge 2 commits into from
Closed

bpo-46588: fix typo in test_calltip.py #31027

wants to merge 2 commits into from

Conversation

caioagiani
Copy link
Contributor

@caioagiani caioagiani commented Jan 30, 2022

  • Lib/idlelib/idle_test/test_calltip.py test_properly_formated → test_properly_formatted

https://bugs.python.org/issue46588

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@caioagiani

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 30, 2022
@caioagiani caioagiani changed the title fix typo in test_calltip.py bpo-46588: fix typo in test_calltip.py Jan 30, 2022
@terryjreedy
Copy link
Member

A trivial fix like this does not require a CLA signature, but I hope you submit it because I hope that this is practice for submitting more substantial patches.

The issue is not needed for this but would be more more substantial patcher.

This should not have a news entry, so please delete it. I cannot delete it because I cannot edit. On the create-PR page, did you uncheck the box to allow others to edit? Or did something else malfunction?

As for the CI failure: the listed error is "default role used". I am not sure what that means here. In any case, everything after the first line should not be present. Did you add it, or did blurb malfunction? The issue number is in the blurb file name.

@caioagiani
Copy link
Contributor Author

A trivial fix like this does not require a CLA signature, but I hope you submit it because I hope that this is practice for submitting more substantial patches.

The issue is not needed for this but would be more more substantial patcher.

This should not have a news entry, so please delete it. I cannot delete it because I cannot edit. On the create-PR page, did you uncheck the box to allow others to edit? Or did something else malfunction?

As for the CI failure: the listed error is "default role used". I am not sure what that means here. In any case, everything after the first line should not be present. Did you add it, or did blurb malfunction? The issue number is in the blurb file name.

Should I remove "https://bugs.python.org/issue46588" ?

I also sent my form for CLA release.

@terryjreedy
Copy link
Member

We can only close, not remove issues, and best to close as 'fixed'. Just remove the blurb and tests should pass.

CLA recording take a day or two.

@caioagiani caioagiani changed the title bpo-46588: fix typo in test_calltip.py bpo-46588: fix typo in test_calltip.py Jan 31, 2022
@caioagiani
Copy link
Contributor Author

We can only close, not remove issues, and best to close as 'fixed'. Just remove the blurb and tests should pass.

CLA recording take a day or two.

Change by Caio Agiani

resolution: -> fixed
stage: patch review -> resolved
status: open -> closed

How can we retry tests?

@terryjreedy
Copy link
Member

How can we retry tests? By changing the diff. In this case, deleting the blurb will trigger retest. Otherwise , close and open the PR, but don't do that.

@terryjreedy
Copy link
Member

Why did you close it? If you don't remove the blurb soon, I will make a new PR without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants