bpo-46528: Simplify BUILD_TUPLE/UNPACK_SEQUENCE folding
#31039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
requested changes
Feb 1, 2022
| case BUILD_TUPLE: | ||
| if (nextop == UNPACK_SEQUENCE && oparg == bb->b_instr[i+1].i_oparg) { | ||
| switch(oparg) { | ||
| case 1: | ||
| inst->i_opcode = NOP; | ||
| bb->b_instr[i+1].i_opcode = NOP; | ||
| break; | ||
| continue; |
There was a problem hiding this comment.
Why change this? Aren't they equivalent.
Having a continue here distracts from the flow of the code, as it is not the normal way to end a case and increases cognitive load (at least it did for me).
There was a problem hiding this comment.
They’re not quite equivalent: note that I also removed the break on old line 8675.
Previously, values other than 1, 2, or 3 wouldn’t get a chance to hit fold_tuple_on_constants. Now they do.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
markshannon
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix
test_pack_unpack.https://bugs.python.org/issue46528