Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46581: Propagate private vars via _GenericAlias.copy_with #31061

Merged
merged 9 commits into from
Mar 10, 2022
Merged

bpo-46581: Propagate private vars via _GenericAlias.copy_with #31061

merged 9 commits into from
Mar 10, 2022

Commits on Mar 9, 2022

  1. bpo-46581: Propagate private vars via _GenericAlias.copy_with 

    pythonGH-26091 added the _typevar_types and _paramspec_tvars instance
variables to _GenericAlias. However, they were not propagated
consistently. This commit addresses the most prominent deficiency
identified in bpo-46581 (namely their absence from
_GenericAlias.copy_with), but there could be others.
    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    90bdf0d View commit details
    Browse the repository at this point in the history

  2. Move tests to test_typing

    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    19e9207 View commit details
    Browse the repository at this point in the history

  3. Move copy edits to python#31684

    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    e30f7ea View commit details
    Browse the repository at this point in the history

  4. Update Lib/typing.py 

    Adopt @Fidget-Spinner's suggestion.

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
    @posita @Fidget-Spinner
    posita and Fidget-Spinner committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    06bd0c3 View commit details
    Browse the repository at this point in the history

  5. Adopt @serhiy-storchaka's suggestions for approach

    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    2cd8199 View commit details
    Browse the repository at this point in the history

  6. Remove redunant in-test imports

    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    b222b3d View commit details
    Browse the repository at this point in the history

  7. Recraft test to not depend on internal details

    @posita
    posita committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    ad0431d View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Move test to ParamSpecTests

    @posita
    posita committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    6db57f5 View commit details
    Browse the repository at this point in the history

  2. Update Lib/test/test_typing.py

    @serhiy-storchaka
    serhiy-storchaka committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    031c617 View commit details
    Browse the repository at this point in the history