Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44359: Fix test_ftplib unhandled thread exceptions #31069

Merged
merged 1 commit into from Feb 2, 2022
Merged

bpo-44359: Fix test_ftplib unhandled thread exceptions #31069

merged 1 commit into from Feb 2, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 2, 2022 •
edited by bedevere-bot

test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.

https://bugs.python.org/issue44359

@vstinner
bpo-44359: Fix test_ftplib unhandled thread exceptions
980940f 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
@vstinner vstinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 2, 2022
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 2, 2022
@vstinner
Copy link
Member Author

vstinner commented Feb 2, 2022

Without this PR, ./python -m test -u all --fail-env-changed test_ftplib -v -m test_makeport always fails on the Fedora Rawhide x64-64 buildbot worker.

With this PR, this command pass and ./python -m test -u all --fail-env-changed test_ftplib -W -j10 -F also runs successfully test_ftplib 30 times (I stopped the command manually).

@vstinner vstinner merged commit 0611eaf into python:main Feb 2, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_ftplib_handle_error branch February 2, 2022 01:47
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2022
@vstinner @miss-islington
bpo-44359: Fix test_ftplib unhandled thread exceptions (pythonGH-31069)
22af44f 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
(cherry picked from commit 0611eaf)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 2, 2022
@bedevere-bot
Copy link

GH-31070 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2022
@vstinner @miss-islington
bpo-44359: Fix test_ftplib unhandled thread exceptions (pythonGH-31069)
1a0b898 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
(cherry picked from commit 0611eaf)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-31071 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 2, 2022
miss-islington added a commit that referenced this pull request Feb 2, 2022
@miss-islington @vstinner
bpo-44359: Fix test_ftplib unhandled thread exceptions (GH-31069)
85b421f 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
(cherry picked from commit 0611eaf)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Feb 2, 2022
@miss-islington @vstinner
bpo-44359: Fix test_ftplib unhandled thread exceptions (GH-31069)
0371e5d 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
(cherry picked from commit 0611eaf)

Co-authored-by: Victor Stinner <vstinner@python.org>
orsenthil
orsenthil reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) LGTM.

@vstinner
Copy link
Member Author

vstinner commented Feb 2, 2022

:-) LGTM.

Thanks for the post merge reviw, I appreciate it, it makes me more confident :-) I wrote a long rationale in the bpo.

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @vstinner @hello-adam
bpo-44359: Fix test_ftplib unhandled thread exceptions (pythonGH-31069)
dbc313a 
test_ftplib now silently ignores socket errors to prevent logging
unhandled threading exceptions.
(cherry picked from commit 0611eaf)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vstinner @miss-islington @bedevere-bot @orsenthil @JelleZijlstra @the-knights-who-say-ni