bpo-45948: Remove constructor discrepancy in C version of ElementTree.XMLParser
#31152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.9
serhiy-storchaka
approved these changes
Feb 12, 2022
|
Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2022
….XMLParser (pythonGH-31152) Both implementations accept target=None now. (cherry picked from commit 168fd64) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
|
Sorry, @jacobtylerwalls and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-31292 is a backport of this pull request to the 3.10 branch. |
jacobtylerwalls
added a commit
to jacobtylerwalls/cpython
that referenced
this pull request
Feb 12, 2022
…ntTree.XMLParser (pythonGH-31152) Both implementations accept target=None now. (cherry picked from commit 168fd64)
|
GH-31299 is a backport of this pull request to the 3.9 branch. |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ntTree.XMLParser (pythonGH-31152) (pythonGH-31299) Both implementations accept target=None now. (cherry picked from commit 168fd64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-45948
Bring the C implementation of
ElementTreeinto agreement with the Python implementation (and the docs) if an explicittarget=Noneis provided toXMLParser. In that case, provide a defaultTreeBuilder.This already worked if the
targetkeyword was omitted. It's possible the reporter only discovered the discrepancy when the arguments went keyword-only in 3.8.https://bugs.python.org/issue45948