Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46672: fix NameError in asyncio.gather if type check fails #31187

Merged
merged 2 commits into from Feb 20, 2022
Merged

bpo-46672: fix NameError in asyncio.gather if type check fails #31187

merged 2 commits into from Feb 20, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 7, 2022 •
edited by bedevere-bot

I am a bit unsure about the full coverage of if outer is None or outer.done(): condition. Does it cover all corner cases?

https://bugs.python.org/issue46672

@sobolevn sobolevn added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 7, 2022
@sobolevn @AlexWaygood
Update Misc/NEWS.d/next/Library/2022-02-07-13-15-16.bpo-46672.4swIjx.rst
7b35c03 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
kumaraditya303
kumaraditya303 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JelleZijlstra
JelleZijlstra approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the new test fails without the fix.

@asvetlov asvetlov merged commit 4ab8167 into python:main Feb 20, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @asvetlov, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4ab8167b9c60d1a04b2e3116d0c52db254b68cda 3.9

@bedevere-bot
Copy link

GH-31440 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 20, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2022
@sobolevn @miss-islington
bpo-46672: fix NameError in asyncio.gather if type check fails (p…
d1d2bc7 
…ythonGH-31187)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 4ab8167)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 20, 2022
@bedevere-bot
Copy link

GH-31441 is a backport of this pull request to the 3.9 branch.

asvetlov pushed a commit to asvetlov/cpython that referenced this pull request Feb 20, 2022
@sobolevn @asvetlov
[3.9] bpo-46672: fix NameError in asyncio.gather if type check fa…
4fa91ec 
…ils (pythonGH-31187)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>.
(cherry picked from commit 4ab8167)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
asvetlov added a commit that referenced this pull request Feb 20, 2022
@asvetlov @sobolevn
[3.9] bpo-46672: fix NameError in asyncio.gather if type check fa…
a6116a9 
…ils (GH-31187) (GH-31441)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
asvetlov pushed a commit that referenced this pull request Feb 20, 2022
@miss-islington @sobolevn
bpo-46672: fix NameError in asyncio.gather if type check fails (G…
f1916cd 
…H-31187) (GH-31440)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 4ab8167)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@asvetlov @sobolevn @hello-adam
[3.9] bpo-46672: fix NameError in asyncio.gather if type check fa…
8ffe03a 
…ils (pythonGH-31187) (pythonGH-31441)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@asvetlov asvetlov asvetlov approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

@asvetlov asvetlov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sobolevn @miss-islington @bedevere-bot @asvetlov @JelleZijlstra @kumaraditya303 @AlexWaygood @the-knights-who-say-ni