Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46685: cover TypeError of ForwardRef(1) in test_typing #31223

Merged
merged 1 commit into from Feb 9, 2022
Merged

bpo-46685: cover TypeError of ForwardRef(1) in test_typing #31223

merged 1 commit into from Feb 9, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 8, 2022 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Feb 8, 2022
@sobolevn sobolevn added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 8, 2022
@corona10 corona10 merged commit d2d1d49 into python:main Feb 9, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 9, 2022
@sobolevn @miss-islington
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (pyt…
afd1f05 
…honGH-31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 9, 2022
@bedevere-bot
Copy link

GH-31229 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 9, 2022
@sobolevn @miss-islington
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (pyt…
5ace575 
…honGH-31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-31230 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 9, 2022
miss-islington added a commit that referenced this pull request Feb 9, 2022
@miss-islington @sobolevn
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (GH-…
d29bbc2 
…31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Feb 9, 2022
@miss-islington @sobolevn
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (GH-…
bde3765 
…31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @sobolevn @hello-adam
bpo-46685: cover TypeError of ForwardRef(1) in test_typing (pyt…
d1bde53 
…honGH-31223)

(cherry picked from commit d2d1d49)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sobolevn @miss-islington @bedevere-bot @corona10 @the-knights-who-say-ni