Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46643: Fix stringized P.args/P.kwargs with get_type_hints #31238

Merged
merged 2 commits into from Mar 3, 2022
Merged

bpo-46643: Fix stringized P.args/P.kwargs with get_type_hints #31238

merged 2 commits into from Mar 3, 2022

Conversation

GBeauregard
Copy link
Contributor

@GBeauregard GBeauregard commented Feb 9, 2022 •
edited by bedevere-bot

There's discussion since fixing this also allows using P.args and P.kwargs inside typing.Annotated. See the bpo issue. We should wait for that discussion to resolve first.

https://bugs.python.org/issue46643

TheOnlyWayUp
TheOnlyWayUp approved these changes Feb 10, 2022
View reviewed changes
Copy link

@TheOnlyWayUp TheOnlyWayUp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GBeauregard
Copy link
Contributor Author

We should be able to move forward with this now re: https://mail.python.org/archives/list/typing-sig@python.org/thread/WZ4BCFO4VZ7U4CZ4FSDQNFAKPG2KOGCL/

@GBeauregard GBeauregard marked this pull request as ready for review March 1, 2022 17:31
JelleZijlstra
JelleZijlstra approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @gvanrossum planning to merge this small typing change.

@JelleZijlstra JelleZijlstra self-assigned this Mar 2, 2022
@JelleZijlstra JelleZijlstra added the needs backport to 3.10 only security fixes label Mar 3, 2022
@JelleZijlstra JelleZijlstra merged commit 75d2d94 into python:main Mar 3, 2022
@miss-islington
Copy link
Contributor

Thanks @GBeauregard for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-31646 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2022
@GBeauregard @miss-islington
bpo-46643: Fix stringized P.args/P.kwargs with get_type_hints (python…
a19c618 
…GH-31238)

(cherry picked from commit 75d2d94)

Co-authored-by: Gregory Beauregard <greg@greg.red>
miss-islington added a commit that referenced this pull request Mar 3, 2022
@miss-islington @GBeauregard
bpo-46643: Fix stringized P.args/P.kwargs with get_type_hints (GH-31238)
257f5be 
(cherry picked from commit 75d2d94)

Co-authored-by: Gregory Beauregard <greg@greg.red>
@sweeneyde
Copy link
Member

sweeneyde commented Mar 3, 2022 •
edited

sphinx-lint was added after the most recent CI job ran on this PR, so it looks like we need to add a newline at the end of the NEWS entry to fix Azure Pipelines check.

Blurb-it was fixed at python/blurb_it#256.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 3, 2022 via email

@JelleZijlstra
Copy link
Member

Fix in #31651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@TheOnlyWayUp TheOnlyWayUp TheOnlyWayUp approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@GBeauregard @miss-islington @bedevere-bot @sweeneyde @JelleZijlstra @sobolevn @TheOnlyWayUp @the-knights-who-say-ni