bpo-46732: fix __bool__ docstring

[JelleZijlstra]

https://bugs.python.org/issue46732

[sweeneyde]

I have no preference between Return True if self else False versus Return bool(self), but either way this is a clear improvement over the existing docstring, so it LGTM.

[merwok]

I have no preference between Return True if self else False versus Return bool(self)

I think these docstrings (like abs(self)) mean implements abs(self), not the redundant returns abs(self).

After discussing counter-proposals, I’m +1 too for the True if self else False proposal. if self is the important part, and can be glossed by teachers or mentors to explain what boolean contexts are.

[JelleZijlstra]

Thanks @merwok! Planning to merge this in a few days since there are multiple approvals and the change is low-risk (cc @gvanrossum).

[gvanrossum]

I read the discussion and I agree that this is the best wording.

[terryjreedy]

See comment

[bedevere-bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[JelleZijlstra]

I have made the requested changes; please review again

Well, not exactly, but the requested changes would be either incorrect or inconsistent with other similar docstrings. I'd be OK with making the docstring bool(self) instead, if that's people's preference.

[bedevere-bot]

Thanks for making the requested changes!

@gvanrossum, @terryjreedy, @merwok, @sweeneyde: please review the changes made to this pull request.

The kind of change I would like is not sensibly possible.

[miss-islington]

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

[bedevere-bot]

GH-31473 is a backport of this pull request to the 3.10 branch.

[bedevere-bot]

GH-31474 is a backport of this pull request to the 3.9 branch.

[JelleZijlstra]

Thanks everyone for the reviews and feedback!