Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46762: Fix an assert failure in f-strings where > or < is the last character if the f-string is missing a trailing right brace. #31365

Merged
merged 5 commits into from Feb 16, 2022
Merged

bpo-46762: Fix an assert failure in f-strings where > or < is the last character if the f-string is missing a trailing right brace. #31365

merged 5 commits into from Feb 16, 2022

Conversation

ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Feb 16, 2022 •
edited by bedevere-bot

@ericvsmith
For multi-character tokens like <=, >=, ==, fix assert when the first…
f915add 
… character is the last character in an f-string missing the trailing right brace.
@ericvsmith ericvsmith self-assigned this Feb 16, 2022
@ericvsmith ericvsmith added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 16, 2022
@ericvsmith ericvsmith changed the title bpo-46762: Fix an assert failure in f-strings where >, <, or = is the last character if the f-string is missing a trailing right brace. bpo-46762: Fix an assert failure in f-strings where > or < is the last character if the f-string is missing a trailing right brace. Feb 16, 2022
@ericvsmith ericvsmith merged commit ffd9f8f into python:main Feb 16, 2022
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@ericvsmith: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2022
@ericvsmith @miss-islington
bpo-46762: Fix an assert failure in f-strings where > or < is the las…
95b208f 
…t character if the f-string is missing a trailing right brace. (pythonGH-31365)

(cherry picked from commit ffd9f8f)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot
Copy link

GH-31370 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2022
@ericvsmith @miss-islington
bpo-46762: Fix an assert failure in f-strings where > or < is the las…
f25346b 
…t character if the f-string is missing a trailing right brace. (pythonGH-31365)

(cherry picked from commit ffd9f8f)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 16, 2022
@bedevere-bot
Copy link

GH-31371 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Feb 16, 2022
@miss-islington @ericvsmith
bpo-46762: Fix an assert failure in f-strings where > or < is the las…
3d407b9 
…t character if the f-string is missing a trailing right brace. (GH-31365)

(cherry picked from commit ffd9f8f)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 16, 2022
@miss-islington @ericvsmith
bpo-46762: Fix an assert failure in f-strings where > or < is the las…
a657bff 
…t character if the f-string is missing a trailing right brace. (GH-31365)

(cherry picked from commit ffd9f8f)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @ericvsmith @hello-adam
bpo-46762: Fix an assert failure in f-strings where > or < is the las…
32f87fa 
…t character if the f-string is missing a trailing right brace. (pythonGH-31365)

(cherry picked from commit ffd9f8f)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@ericvsmith ericvsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericvsmith @miss-islington @bedevere-bot @the-knights-who-say-ni