bpo-46822: Increase timeout for test_create_server_ssl_over_ssl to match underlying timeouts #31502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch underlying timeouts
asvetlov
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
LGTM.
The initial timeout is borrowed from uvloop tests, which are executed on relatively fast local machines and GitHub CI.
The timeout increase is completely satisfactory. The number can be raised even to minutes, it's ok. The only thing I'd like to avoid is complete timeout removal: it can lead to weird hangs potentially, better to fail loudly.
|
Rather than hardcoded values, you can use support.SHORT_TIMEOUT and support.LONG_TIMEOUT: These timeout values are increased on slow buildbots based on regrtest --timeout parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46822