Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46860: Respect --with-suffix on case-insensitive file systems #31593

Merged
merged 4 commits into from Mar 2, 2022
Merged

bpo-46860: Respect --with-suffix on case-insensitive file systems #31593

merged 4 commits into from Mar 2, 2022

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Feb 26, 2022 •
edited by bedevere-bot

Prior to this change the suffix of the binary was forced to .exe.

https://bugs.python.org/issue46860

@brettcannon brettcannon mentioned this pull request Feb 26, 2022
Closed
@brettcannon
Copy link
Member Author

I suspect that I somehow have the wrong combination of some tooling in order to regenerate configure, but the regenerated files check seems to be failing due to runstatedir being removed. Following https://devguide.python.org/setup/#regenerate-configure, I did install all the requisite packages from Homebrew and am specifically using autoconf 2.69.

@ned-deily
Copy link
Member

Regenerating configure isn't so simple anymore :( See https://bugs.python.org/issue44035 where @tiran provides a link to containers that provide the canonical version of autoconf.

@brettcannon
Copy link
Member Author

Ugh, so now we require either Linux or some container runtime in order to update ./configure? It might be time to update to either autoconf 2.71 or consider moving to CMake.

I'm downloading Docker Desktop for Mac now, so hopefully I can get this PR fixed in the next week or so.

@brettcannon brettcannon self-assigned this Feb 26, 2022
@thomasballinger
Copy link

@brettcannon this indeed addresses one of the issues I had with the WebAssembly build on Mac with https://github.com/ethanhs/python-wasm

@brettcannon brettcannon merged commit 50ec345 into python:main Mar 2, 2022
@brettcannon brettcannon deleted the case-insensitive-honour-with-suffix branch March 2, 2022 22:24
@hongweipeng hongweipeng mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brettcannon @ned-deily @thomasballinger @the-knights-who-say-ni @bedevere-bot