Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31203: Added constant socket.IP_PKTINFO #3161

Conversation

guyincognito-io
Copy link

@guyincognito-io guyincognito-io commented Aug 20, 2017

@tiran
Copy link
Member

tiran commented Sep 7, 2017

Your patch is missing a news entry. Please use the blurb tool to generate it, https://pypi.python.org/pypi/blurb

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blurb is missing.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor

@AllesCoolAllesBestens, please take a look at the review request here and the comment on the bug tracker issue. Thank you!

@alimcmaster1
Copy link

Looks like this is stale - @csabella are we good to close?

@csabella
Copy link
Contributor

csabella commented May 23, 2020

@alimcmaster1, thanks for the ping. Yes, I'm going to close this due to inactivity. It can be reopened if the original author is interested in working on it or a new PR can be created to replace it. If a new PR is created and uses the original change, please give credit to @AllesCoolAllesBestens in the pull request message.

It looks like it's already been replaced by #20029. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants