New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46889 Add compile flag for math support for sqlite3 on macos #31635
Conversation
Mac/BuildScript/build-installer.py
Outdated
@@ -369,6 +369,7 @@ def library_recipes(): | |||
'-DSQLITE_ENABLE_RTREE ' | |||
'-DSQLITE_OMIT_AUTOINIT ' | |||
'-DSQLITE_TCL=0 ' | |||
'-DSQLITE_ENABLE_MATH_FUNCTIONS' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a trailing space like in the previous lines in case we need to add another option in the future.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Not sure if this is required but I didn't see a CI/CD pipeline for macos 12.1 aarch64 so I ran the tests offline:
|
Thanks for the test, but you do understand that this change will only affect the building of macOS installer packages like those released on python.org. Regular builds, including CI ones, use whatever libsqlite3 is available, by default the one provided by Apple in macOS or possibly one provided by a third-party distributor like MacPorts or Homebrew. In the meantime, we do need you to fill out the contributor agreement as noted above. |
See @erlend-aasland's comment on the bpo issue: this option is enabled by default on Unix builds and so the math functions are already present with current python.org macOS installers. But thanks for your contribution! |
Adds support for sqlite3 math functions on macos: https://bugs.python.org/issue46889
https://bugs.python.org/issue46889