Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91102: Use Argument Clinic for EncodingMap #31725

Merged
merged 7 commits into from
Apr 18, 2022
Merged

gh-91102: Use Argument Clinic for EncodingMap #31725

merged 7 commits into from
Apr 18, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Mar 7, 2022 •
edited
Loading

A part of #91102.

@arhadthedev arhadthedev marked this pull request as draft March 7, 2022 14:19
@arhadthedev arhadthedev marked this pull request as ready for review March 7, 2022 15:01
@arhadthedev arhadthedev changed the title bpo-46946: Port EncodingMap from the core to Argument Clinic gh-91102: Port EncodingMap from the core to Argument Clinic Apr 12, 2022
@arhadthedev arhadthedev changed the title gh-91102: Port EncodingMap from the core to Argument Clinic gh-91102: Port EncodingMap to Argument Clinic Apr 12, 2022
@arhadthedev
Copy link
Member Author

The change is internal so no NEWS entry is required.

@arhadthedev arhadthedev changed the title gh-91102: Port EncodingMap to Argument Clinic gh-91102: Use Argument Clinic for EncodingMap Apr 13, 2022
JelleZijlstra
JelleZijlstra reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but could you add a NEWS entry? The class is actually accessible from Python:

>>> _codecs.charmap_build("\0abc")
<EncodingMap object at 0x1052ff790>

@JelleZijlstra JelleZijlstra self-assigned this Apr 18, 2022
@arhadthedev
Copy link
Member Author

Addressed.

@JelleZijlstra JelleZijlstra self-requested a review April 18, 2022 04:28
@JelleZijlstra JelleZijlstra merged commit 2f0fc52 into python:main Apr 18, 2022
@arhadthedev arhadthedev deleted the ac-encodingmap branch April 19, 2022 05:19
@arhadthedev arhadthedev mentioned this pull request Apr 30, 2022
Closed
@arhadthedev arhadthedev mentioned this pull request May 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arhadthedev @JelleZijlstra @the-knights-who-say-ni @bedevere-bot