bpo-47032: Ensure Windows install builds fail correctly with a non-zero exit code when part of the build fails #31921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro exit code when part of the build fails
zooba
added
OS-windows
needs backport to 3.9
|
That merge commit has the fix for the issue that caused MSI failures, which means that this change has successfully fixed broken CI :D |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @zooba, I could not cleanly backport this to |
|
Sorry @zooba, I had trouble checking out the |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 16, 2022
…ro exit code when part of the build fails (pythonGH-31921)
|
GH-31926 is a backport of this pull request to the 3.10 branch. |
|
GH-31927 is a backport of this pull request to the 3.9 branch. |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 16, 2022
…ro exit code when part of the build fails (pythonGH-31921)
miss-islington
pushed a commit
that referenced
this pull request
Mar 16, 2022
miss-islington
pushed a commit
that referenced
this pull request
Mar 16, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…non-zero exit code when part of the build fails (pythonGH-31921) (pythonGH-31927) Automerge-Triggered-By: GH:zooba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue47032