Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47037: Test debug builds on Windows in CI so that native assertions are noticed sooner #31965

Merged
merged 3 commits into from Mar 18, 2022
Merged

bpo-47037: Test debug builds on Windows in CI so that native assertions are noticed sooner #31965

merged 3 commits into from Mar 18, 2022
+4 −4

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 17, 2022 •
edited by bedevere-bot

@zooba
Copy link
Member Author

zooba commented Mar 17, 2022

The good news is that the build now fails because of the assert message :-)

Not sure why it was slower to build though... debug builds should be significantly faster than release builds. Will re-run it once the assertion is fixed though, since that'll require a merge.

@zooba zooba merged commit d0a91bd into python:main Mar 18, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-47037 branch March 18, 2022 17:19
@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d0a91bd277d1122b41d59e8022b596e3b3ae24fe 3.10

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d0a91bd277d1122b41d59e8022b596e3b3ae24fe 3.9

@zooba zooba removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 18, 2022
@zooba
Copy link
Member Author

zooba commented Mar 18, 2022

I don't actually care that much about a backport. It probably matters more to check release builds for maintenance branches anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zooba @miss-islington @the-knights-who-say-ni @bedevere-bot