Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47095: Use libb2 to provide blake2 implementation (GH-32059) #32059

Merged
merged 7 commits into from
Mar 26, 2022
Merged

bpo-47095: Use libb2 to provide blake2 implementation (GH-32059) #32059

merged 7 commits into from
Mar 26, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 22, 2022 •
edited by bedevere-bot
Loading

@tiran tiran requested a review from gpshead March 22, 2022 21:02
gpshead
gpshead reviewed Mar 22, 2022
View reviewed changes
Makefile.pre.in Outdated Show resolved Hide resolved
Modules/_blake2/blake2module.h Outdated Show resolved Hide resolved
@gpshead gpshead changed the title Use libb2 to provide blake2 implementation bpo-47095: Use libb2 to provide blake2 implementation Mar 23, 2022
@tiran tiran marked this pull request as ready for review March 23, 2022 11:52
@tiran tiran requested a review from gpshead March 25, 2022 18:57
@tiran
Copy link
Member Author

tiran commented Mar 25, 2022

@gpshead please take another look

gpshead
gpshead reviewed Mar 26, 2022
View reviewed changes
Doc/whatsnew/3.11.rst Outdated
@@ -1060,6 +1066,9 @@ Porting to Python 3.11
<https://github.com/python/pythoncapi_compat>`__ to get these functions
on old Python functions.

* Distributors are encouraged to build Python with optimized Blake2 library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... with the optimized external ...

@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 26, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 693185f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 26, 2022
@tiran tiran changed the title bpo-47095: Use libb2 to provide blake2 implementation bpo-47095: Use libb2 to provide blake2 implementation (GH-32059) Mar 26, 2022
@tiran tiran merged commit b16b6bb into python:main Mar 26, 2022
@tiran tiran deleted the libb2 branch March 26, 2022 19:52
@tiran tiran mentioned this pull request May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @bedevere-bot @gpshead @the-knights-who-say-ni