Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase #32086

Merged
merged 1 commit into from Mar 23, 2022
Merged

bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase #32086

merged 1 commit into from Mar 23, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Mar 23, 2022 •
edited by bedevere-bot

@asvetlov asvetlov requested a review from 1st1 as a code owner March 23, 2022 20:47
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 23, 2022
@asvetlov asvetlov added needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes and removed tests Tests in the Lib/test dir labels Mar 23, 2022
@asvetlov asvetlov merged commit ff619c7 into main Mar 23, 2022
@asvetlov asvetlov deleted the rewrite-asyncio-threads-tests branch March 23, 2022 21:17
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-32087 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 23, 2022
@bedevere-bot
Copy link

GH-32088 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2022
@asvetlov @miss-islington
bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTest…
3294625 
…Case (pythonGH-32086)

(cherry picked from commit ff619c7)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2022
@asvetlov @miss-islington
bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTest…
9114f15 
…Case (pythonGH-32086)

(cherry picked from commit ff619c7)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington added a commit that referenced this pull request Mar 23, 2022
@miss-islington @asvetlov
bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTest…
9e1bfd8 
…Case (GH-32086)

(cherry picked from commit ff619c7)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@asvetlov asvetlov mentioned this pull request Apr 18, 2022
Closed
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Apr 18, 2022
@kumaraditya303
Revert "bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsy…
3eac828 
…ncioTestCase (pythonGH-32086)"

This reverts commit 9e1bfd8.
@gpshead gpshead mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni