Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47117: Don't crash if we fail to decode characters when the tokenizer buffers are uninitialized #32129

Merged
merged 2 commits into from Mar 26, 2022
Merged

bpo-47117: Don't crash if we fail to decode characters when the tokenizer buffers are uninitialized #32129

merged 2 commits into from Mar 26, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 26, 2022 •
edited by miss-islington

https://bugs.python.org/issue47117

Automerge-Triggered-By: GH:pablogsal

@pablogsal
Copy link
Member Author

pablogsal commented Mar 26, 2022 •
edited

Testing this programatically is close to impossible :(

isidentical
isidentical approved these changes Mar 26, 2022
View reviewed changes
Copy link
Sponsor Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried to write a test, but no luck on reproducing the same behavior. The changes LGTM

Parser/pegen_errors.c Show resolved Hide resolved
@pablogsal @isidentical
Update Parser/pegen_errors.c
1085aaa 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 26cca80 into python:main Mar 26, 2022
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 26cca8067bf5306e372c0e90036d832c5021fd90 3.10

@miss-islington miss-islington self-assigned this Mar 26, 2022
@bedevere-bot
Copy link

GH-32130 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 26, 2022
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 26, 2022
@pablogsal
[3.10] bpo-47117: Don't crash if we fail to decode characters when th…
5dc868b 
…e tokenizer buffers are uninitialized (pythonGH-32129)

Automerge-Triggered-By: GH:pablogsal.
(cherry picked from commit 26cca80)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Mar 26, 2022
@pablogsal
[3.10] bpo-47117: Don't crash if we fail to decode characters when th…
27ee431 
…e tokenizer buffers are uninitialized (GH-32129) (GH-32130)

Automerge-Triggered-By: GH:pablogsal.
(cherry picked from commit 26cca80)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical isidentical approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@miss-islington miss-islington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @miss-islington @bedevere-bot @isidentical @the-knights-who-say-ni